gh-144991: Use runtime JIT threshold in _testinternalcapi#145496
gh-144991: Use runtime JIT threshold in _testinternalcapi#145496corona10 merged 4 commits intopython:mainfrom
Conversation
|
|
Modules/_testinternalcapi.c
Outdated
| if (PyModule_Add(module, "TIER2_THRESHOLD", | ||
| // + 1 more due to one loop spent on tracing. | ||
| PyLong_FromLong(JUMP_BACKWARD_INITIAL_VALUE + 2)) < 0) { | ||
| PyLong_FromLong(interp->opt_config.jump_backward_initial_value + 2)) < 0) { |
There was a problem hiding this comment.
You may use PyLong_FromUnsignedLong() since the member is unsigned (uint16_t). Suggestion to use shorter lines:
PyInterpreterState *interp = PyInterpreterState_Get();
// + 1 more due to one loop spent on tracing.
unsigned long threshold = interp->opt_config.jump_backward_initial_value + 2;
if (PyModule_Add(module, "TIER2_THRESHOLD",
PyLong_FromUnsignedLong(threshold)) < 0) {
return 1;
}|
"aarch64-pc-windows-msvc/msvc (Debug)" failed with:
The recent change commit e6c3c04 added a new static type to |
Co-authored-by: Victor Stinner <vstinner@python.org>
| /* For now we hard-code this to a value for which we are confident | ||
| all the static builtin types will fit (for all builds). */ | ||
| #define _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES 201 | ||
| #define _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES 202 |
There was a problem hiding this comment.
Because a new static type was added recently, and JIT tests crash or fail with an assertion error without this change: #145496 (comment)
test_sysfails withPYTHON_JIT_STRESS=1#144991